Skip to content

OCPEDGE-2934: feat: add macAddress as alternative identifier for fencing credentials - #1916

Open
fracappa wants to merge 1 commit into
openshift-metal3:masterfrom
fracappa:fca/fencing-credentials-macaddress-support
Open

OCPEDGE-2934: feat: add macAddress as alternative identifier for fencing credentials#1916
fracappa wants to merge 1 commit into
openshift-metal3:masterfrom
fracappa:fca/fencing-credentials-macaddress-support

Conversation

@fracappa

@fracappa fracappa commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Introduce FENCING_CREDENTIALS_IDENTIFIER env var to control whether fencing credentials identify nodes by hostname (default) or macAddress.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2026
@openshift-ci
openshift-ci Bot requested review from bfournie and celebdor June 19, 2026 09:19
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 19, 2026
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

Hi @fracappa. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fracappa
fracappa force-pushed the fca/fencing-credentials-macaddress-support branch 2 times, most recently from a0ee3a7 to b1b2692 Compare July 16, 2026 14:07
@fracappa
fracappa force-pushed the fca/fencing-credentials-macaddress-support branch from 0c17b82 to b1b2692 Compare August 4, 2026 12:28
@fracappa
fracappa force-pushed the fca/fencing-credentials-macaddress-support branch from b1b2692 to aaa2b9a Compare August 18, 2026 12:06
@fracappa
feat: add macAddress as alternative identifier for fencing credentials
8eb12dc 
Introduce FENCING_CREDENTIALS_IDENTIFIER env var to control whether
fencing credentials identify nodes by hostname (default) or macAddress.
@fracappa
fracappa force-pushed the fca/fencing-credentials-macaddress-support branch from aaa2b9a to 8eb12dc Compare August 18, 2026 12:08
@fracappa fracappa changed the title WIP: feat: add macAddress as alternative identifier for fencing credentials OCPEDGE-2934: feat: add macAddress as alternative identifier for fencing credentials Aug 18, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2026
@elfosardo

elfosardo commented Aug 18, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2026
@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown

@fracappa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-5control-ipv4 8eb12dc link false /test e2e-agent-5control-ipv4
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 8eb12dc link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 8eb12dc link false /test e2e-agent-compact-ipv4-iso-no-registry
ci/prow/e2e-metal-ipi-ovn-ipv4-bond 8eb12dc link false /test e2e-metal-ipi-ovn-ipv4-bond
ci/prow/e2e-metal-ovn-arbiter 8eb12dc link false /test e2e-metal-ovn-arbiter

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bfournie bfournie Awaiting requested review from bfournie
@celebdor celebdor Awaiting requested review from celebdor

Assignees

No one assigned

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fracappa @elfosardo